Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Run tests against the shared integration testsuite #8

Closed
stof opened this issue Jan 5, 2017 · 6 comments
Closed

[Suggestion] Run tests against the shared integration testsuite #8

stof opened this issue Jan 5, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@stof
Copy link
Contributor

stof commented Jan 5, 2017

https://github.com/php-cache/integration-tests maintains a set of integration tests for PSR cache implementations. As of 0.14.0, it supports PSR-16 too rather than only PSR-6 (the readme does not showcase it, but I opened a PR updating it at php-cache/integration-tests#68

It would be great to run tests against it too (without mocking doctrine/cache), to ensure that it behaves properly according to the spec.

@stof
Copy link
Contributor Author

stof commented Jan 5, 2017

Btw, your 1.0 implementation does not respect the spec regarding exceptions...

@asgrim
Copy link
Member

asgrim commented Jan 8, 2017

Tests are added in #12, but we are currently skipping those that fail. This is a bug until resolved therefore.

@asgrim asgrim added the bug label Jan 8, 2017
@asgrim asgrim self-assigned this Jan 19, 2017
@asgrim asgrim added this to the 1.1.0 milestone Jan 19, 2017
@asgrim
Copy link
Member

asgrim commented Jan 20, 2017

Partially implemented in #13 (for TTL) which is now merged, and #15 which is pending resolution of issue discovered in integration test (see: php-cache/integration-tests#74 )

@asgrim
Copy link
Member

asgrim commented Jan 20, 2017

Todo

  • testObjectDoesNotChangeInCache

In Progress

Done

@asgrim
Copy link
Member

asgrim commented Jan 20, 2017

Opened issue #20 for testObjectDoesNotChangeInCache.

@asgrim asgrim closed this as completed Jan 20, 2017
@asgrim
Copy link
Member

asgrim commented Jan 20, 2017

Otherwise, closed by various PRs listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants