Merge pull request #20 from Roave/remove-php73-support

Removed support for PHP 7.3
Roave · Oct 1, 2020 · bbbcc31 · bbbcc31
2 parents 577ee14 + 886ae4d
commit bbbcc31
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 17 deletions.
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -17,7 +17,6 @@ jobs:
           - "highest"
           - "locked"
         php-version:
-          - "7.3"
           - "7.4"
         operating-system:
           - "ubuntu-latest"

diff --git a/composer.json b/composer.json
@@ -3,7 +3,7 @@
     "description": "Sign and verify stuff",
     "license": "MIT",
     "require": {
-        "php": "^7.3 || ^7.4"
+        "php": "7.4.*"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.3",

diff --git a/composer.lock b/composer.lock
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -17,8 +17,5 @@
 
     <rule ref="Doctrine">
         <exclude name="SlevomatCodingStandard.Classes.SuperfluousInterfaceNaming.SuperfluousSuffix"/>
-
-        <!-- Only for php7.3 support for now - to be removed once we drop php7.3 support -->
-        <exclude name="SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint" />
     </rule>
 </ruleset>
diff --git a/src/Encoder/HmacEncoder.php b/src/Encoder/HmacEncoder.php
@@ -9,8 +9,7 @@
 
 final class HmacEncoder implements EncoderInterface
 {
-    /** @var string */
-    private $hmacKey;
+    private string $hmacKey;
 
     public function __construct(string $hmacKey)
     {

diff --git a/src/FileContentChecker.php b/src/FileContentChecker.php
@@ -11,8 +11,7 @@
 
 final class FileContentChecker implements CheckerInterface
 {
-    /** @var EncoderInterface */
-    private $encoder;
+    private EncoderInterface $encoder;
 
     /**
      * {@inheritDoc}

diff --git a/src/FileContentSigner.php b/src/FileContentSigner.php
@@ -8,8 +8,7 @@
 
 final class FileContentSigner implements SignerInterface
 {
-    /** @var EncoderInterface */
-    private $encoder;
+    private EncoderInterface $encoder;
 
     /**
      * {@inheritDoc}