Remove services section from phpstan.neon.dist
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal ScopeIsInClassTypeSpecifyingExtension class is already removed
Ocramius
added
enhancement
|
Yeah, this extension is no longer necessary because the methods in question have After merging this no release is required because this doesn't have any effect to users of this package. |
Ocramius
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Thanks @sasezaki and @ondrejmirtes!
A release is coming anyway, with accumulated changes 👍
|
@ondrejmirtes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ScopeIsInClassTypeSpecifyingExtension class is already removed.
phpstan/phpstan-src@ace76ce
fixes #104
@ondrejmirtes Could you confirm this?