Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build on node 12 #6

Closed
arobinson opened this issue Dec 3, 2019 · 1 comment · Fixed by #7
Closed

Cannot build on node 12 #6

arobinson opened this issue Dec 3, 2019 · 1 comment · Fixed by #7

Comments

@arobinson
Copy link

arobinson commented Dec 3, 2019 •
edited
Loading

Sleep version 3 does not compile with node 12. Is it possible to update it to a newer version?
@korczis korczis mentioned this issue Dec 10, 2019
Merged
@Rob--W Rob--W closed this as completed in #7 Dec 10, 2019
Rob--W added a commit that referenced this issue Dec 10, 2019
@Rob--W
0.3.0 - Bump sleep dependency to 6.1.0
25927c7 
- Updated sleep dependency to 6.1.0 (see #6).
@Rob--W
Copy link
Owner

Rob--W commented Dec 10, 2019

Thanks for your report, and @korczis for the patch. I've published a new version with the bumped dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use sleep version 6.1.0 korczis/node-xvfb
2 participants
@arobinson @Rob--W