Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NO_PROXY lists customizable #11

Closed
Zekfad opened this issue Jul 16, 2020 · 1 comment
Closed

Make NO_PROXY lists customizable #11

Zekfad opened this issue Jul 16, 2020 · 1 comment

Comments

@Zekfad
Copy link

Zekfad commented Jul 16, 2020

Feature request

Expose NO_PROXY lists outside as options or editable prototype property.

Why?

This will allow to use custom no-proxy lists from outside. E.g. like node-gyp use it's own no-proxy implementation.

References

proxy-from-env/index.js

Line 63 in 96d01f8

var NO_PROXY =

Zekfad added a commit to Zekfad/proxy-from-env that referenced this issue Jul 16, 2020
@Zekfad
feat: implement programmatic extension of NO_PROXY lists
4c58a23 
closes Rob--W#11
@Zekfad Zekfad mentioned this issue Jul 16, 2020
Closed
@Rob--W
Copy link
Owner

Rob--W commented Sep 24, 2020

Closing because of https://github.com/Rob--W/proxy-from-env/pull/12#issuecomment-698283916

@Rob--W Rob--W closed this as completed Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add programmatic API for customization NO_PROXY Zekfad/proxy-from-env
2 participants
@Rob--W @Zekfad