Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect NPM configuration #8

Closed
aslushnikov opened this issue Mar 2, 2020 · 2 comments · Fixed by #9
Closed

Respect NPM configuration #8

aslushnikov opened this issue Mar 2, 2020 · 2 comments · Fixed by #9

Comments

@aslushnikov
Copy link
Contributor

NPM can define it's own proxy settings, and these are set as process.env.npm_config_https_proxy, process.env.npm_config_http_proxy, and process.env.npm_config_no_proxy.

proxy-form-env does not respect these, and the only way to use these with proxy-form-env is to spoil the global scope:

https://github.com/puppeteer/puppeteer/blob/0b1a9ceee2f05f534f0d50079ece172d627a93c7/install.js#L54-L65

It'd be nice to support these out of the box, or at least have an option to plug them in.

aslushnikov added a commit to aslushnikov/proxy-from-env that referenced this issue Mar 2, 2020
@Rob--W Rob--W closed this as completed in #9 Mar 4, 2020
Rob--W pushed a commit that referenced this issue Mar 4, 2020
@Rob--W
Copy link
Owner

Rob--W commented Mar 11, 2020

@aslushnikov FYI I have published a new version last week, which includes your patch.

@aslushnikov
Copy link
Contributor Author

@Rob--W thanks! I already picked it up in Playwright :) microsoft/playwright@14a7d1c#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants