-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect NPM configuration #8
Comments
aslushnikov
added a commit
to aslushnikov/proxy-from-env
that referenced
this issue
Mar 2, 2020
Rob--W
pushed a commit
that referenced
this issue
Mar 4, 2020
@aslushnikov FYI I have published a new version last week, which includes your patch. |
@Rob--W thanks! I already picked it up in Playwright :) microsoft/playwright@14a7d1c#diff-b9cfc7f2cdf78a7f4b91a753d10865a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NPM can define it's own proxy settings, and these are set as
process.env.npm_config_https_proxy
,process.env.npm_config_http_proxy
, andprocess.env.npm_config_no_proxy
.proxy-form-env does not respect these, and the only way to use these with
proxy-form-env
is to spoil the global scope:https://github.com/puppeteer/puppeteer/blob/0b1a9ceee2f05f534f0d50079ece172d627a93c7/install.js#L54-L65
It'd be nice to support these out of the box, or at least have an option to plug them in.
The text was updated successfully, but these errors were encountered: