add unit tests for success todo failure

garfield/lookup/tests.py

@@ -1,3 +1,38 @@
 from django.test import TestCase
+from django.http import QueryDict
+from django.test import Client
+import responses
+from .models import Lookup
+from contacts.models import Contact
+from sms.tests.test_sms import GarfieldTwilioTestCase
 
 # Create your tests here.
+
+class TestTwilioLookupTests(GarfieldTwilioTestCase):
+    #create dummy contact
+
+    phoneNumber = "+12222222222"
+    to_number = "+1234456789"
+    from_number = "+1234456789"
+    smsMessageCount = 10
+    callCount = 30
+    contactCount = 20
+    carrier ="Mock Carrier"
+    querydict = QueryDict('',mutable=True)
+    def testSuccess(self):
+        self.Contact = Contact.objects.create(phone_number=self.phoneNumber,
+               sms_message_count = self.smsMessageCount,
+               call_count = self.callCount,
+               contact_count = self.contactCount,
+               carrier = self.carrier) 
+        self.params = {"From":self.from_number,
+              "To":self.to_number,
+              "Body":self.phoneNumber}
+        self.querydict.update(self.params)
+        response = self.client.lookup(from_=self.from_number,to=self.to_number,params=self.querydict)
+        self.assertContains(response,"Number of Texts")
+        self.assertContains(response,self.callCount)
+        self.assertContains(response,self.smsMessageCount)
+        self.assertContains(response,self.contactCount)
+        self.assertContains(response,self.carrier)
+

garfield/lookup/views.py

@@ -54,7 +54,7 @@ def lookup_contact(request):
         in our db and return meta data
         :param request A query dict from twilio 
     """
-    contact_number = request.GET.get('Body')
+    contact_number = request.POST.get('Body')
     try:
       valid = is_valid_number(contact_number)
     except:
@@ -94,7 +94,7 @@ def is_valid_number(number:str):
       raise e
 
 def create_lookup_entry(request, contact_phone_number, related_contact): 
-    from_number = request.GET.get('From')
+    from_number = request.POST.get('From')
     lookup_entry = Lookup.objects.create(officer_phone_number=from_number, contact_phone_number=contact_phone_number, related_contact=related_contact)
     lookup_entry.save()
 

garfield/sms/tests/test_sms.py

@@ -63,6 +63,22 @@ def call(self, to, path="/voice/", from_="+15556667777",
                          HTTP_X_TWILIO_SIGNATURE=signature,
                          HTTP_HOST=HTTP_HOST)
 
+    def lookup(self, to, from_,params,
+             path="/lookup/",extra_params=None):
+        if extra_params:
+            for k, v in extra_params.items():
+                params[k] = v
+
+        HTTP_HOST = "example.com"
+        validator = RequestValidator("yyyyyyyy")
+        absolute_url = "http://{0}{1}".format(HTTP_HOST,
+                                              path)
+        signature = validator.compute_signature(absolute_url,
+                                                params)
+        return self.post(path, params,
+                         HTTP_X_TWILIO_SIGNATURE=signature,
+                         HTTP_HOST=HTTP_HOST)
+
 
 @override_settings(TWILIO_AUTH_TOKEN="yyyyyyyy",
                    ALLOWED_HOSTS=['example.com'])