convert issuer to string prevents php 8.1 errors

[brainfoolong]

By forcing $this->issuer to be string, even if null is set, it prevents throwing errors in PHP 8.1 is rawurlencode is not allowed to have null as parameter.

It would be better to force string to be already in __construct, but this may create a breaking change for existing users.

[willpower232]

Thanks for this, can you add 8.1 to the list of checked versions here and see if there are any other problems reported by tests?

TwoFactorAuth/.github/workflows/test.yml

Line 13 in 042f347

php-version: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0']

[brainfoolong]

Hi, i would like to but unfortunately i don't have time to setup a test environment anytime soon.

[willpower232]

I've just approved running github actions here so if you add that then github actions will do all the testing publicly

[willpower232]

Github can't reproduce the original issue in master, are you able to share the code you used to trigger the problem?

[brainfoolong]

For sure

$tfa = new TwoFactorAuth();
$tfa->getQRText("test", "secret");

[MasterOdin]

See https://github.com/MasterOdin/TwoFactorAuth/commit/66687ba1729125792085543fe7a62801bcf55cad (and failing PHP 8.1 action) which adds a new test case that demonstrates the bug. This also required setting php.ini value as part of setup-php action as for PHP 8.0+, it uses a production php.ini file that sets E_ALL & ~E_DEPRECATED & ~E_STRICT and so would miss the failing test by default (ref: shivammathur/setup-php#450).

[willpower232]

thanks for confirming @MasterOdin, are you able to PR that extra check into this repo as well?

[MasterOdin]

The testcase should probably be included into this PR by @brainfoolong as it fails otherwise. I can make a PR though with the change to setup-php and phpunit.xml configuration.