Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADS1013 & ADS1113 do not have gain #2

Closed
RobTillaart opened this issue Aug 4, 2020 · 0 comments
Closed

ADS1013 & ADS1113 do not have gain #2

RobTillaart opened this issue Aug 4, 2020 · 0 comments
Assignees
@RobTillaart
Labels
bug Something isn't working
Milestone
0.3.0

Comments

@RobTillaart
Copy link
Owner

Must be fixed, It is no showstopper but need at least documentation.

  • in base-class with a _type check in setGain() or
  • move setGain to supporting classes.
  • GetGain() can stay in baseclass (check)
@RobTillaart RobTillaart added the bug Something isn't working label Aug 4, 2020
@RobTillaart RobTillaart added this to the 0.3.0 milestone Aug 4, 2020
@RobTillaart RobTillaart self-assigned this Aug 4, 2020
RobTillaart added a commit that referenced this issue Aug 15, 2020
@RobTillaart
Merge pull request #3 from RobTillaart/develop
1bf0a5d 
fix #2 gain + add _config field
@ghost ghost mentioned this issue Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobTillaart RobTillaart

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@RobTillaart