-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RP2040 Support #21
Conversation
You did a lot of work! Thanks! |
build failed on
If you refactor the begin() the example needs to be rewritten (partially) too. |
A good night sleep later I had some thoughts about the RP2040 support. As I do not have a RP2040 I cannot test this myself. Is it possible to add the Wire or Wire1 instance in the constructor ? MCP4725 mcp(addr, &Wire);
Can you give it a try? The library does not track which Wire is used but is that a problem? |
Yeah, it actually works! But some changes are still required for the output config of the RP2040, since it has some variables for setting the output pins... |
And a useage example cant hurt ;-) |
I'd like to make mention that this requires Arduino-Pico and not the official Arduino Mbed board library (which doesn't have Wire::setSDA/SCL) https://arduino-pico.readthedocs.io/en/latest/install.html#installing-via-arduino-boards-manager |
Thanks for this info. Will read the link later today if time permits. |
Not necessarily? I'm not an expert, but I assume that this is just for Arduino IDE Wire-compatible interfaces. I'm sure you can use other libraries to access it. Part of this is my inexperience with using Arduino IDE with RP2040 (I've only used it with Uno before) but it might be nice to know "hey, you can't just select the default builtin RP2040, you need Arduino-Pico" in the README section. |
Thanks, I better reopen this issue as reminder to add the note in the readme. Mm PRs cannot be reopened. Created issue #23 |
And again added RP2040 Support for this Lib