feature/bytearrayproperty-validation #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinasbardauskas
commented
May 31, 2018
•
justinasbardauskas
commented
- Added ByteArrayProperty validation.
- Added 'validateByteArrayProperties' property to enable/disable validation.
- Removed 'properties validation' duplicated code from DocumentationDrivenValidator and ConsumerDriverValidator. Code moved to PropertyValidator class.
- PropertyValidator : Refactored code. Changed 'instanceOf' operator to Type.class.isAssignableFrom(...). It provides more strict and faster type check operation.
- Introduced swagger model type and format definitions validation in DocumentationDrivenValidator.
- Added tests which cover swagger simple definitions and REF defintions.
- Documentation update.
added 2 commits
May 31, 2018 15:01
* Removed duplicated code of properties validation from DocumentationDrivenValidator and ConsumerDriverValidator. Code moved to PropertyValidator class. * Added 'validateByteArrayProperties' property to enable/disable validation * Introduced model type and format definitions validation in DocumentationDrivenValidator. * Added tests which cover simple swagger definitions and ref definitions.
|
I was just about to start fixing the exact same issue. @RobWin could you please release this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.