Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rajeswari|Nandha] Add OWASP dependency check and fix the vulnerabilities #52

Merged
merged 1 commit into from Feb 1, 2019

Conversation

nandhae
Copy link

@nandhae nandhae commented Sep 21, 2018

We have used assertj-swagger in our project and we also have OWASP dependency checker for analysing vulnerabilities. The dependency checker complained about 2 dependencies of assertj-swagger -> commons-collections and jackson-databind (a dependency of swagger-compat-spec-parser).

This PR adds dependency check analyser to the build and also fixes the existing vulnerabilities by upgrading them to the closest version that has the fix.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.799% when pulling 5acef50 on nandhagr8:vulnerability_fix into ebeda3c on RobWin:master.

@php-coder
Copy link

Any updates on that?

@php-coder
Copy link

Ah, I see (#41) that this project isn't maintained at this moment :(

@RobWin RobWin merged commit 8e0ca65 into RobWin:master Feb 1, 2019
@php-coder
Copy link

@RobWin Thank you! Should we expect a new release soon? :)

@justinasbardauskas
Copy link

@RobWin
Copy link
Owner

RobWin commented Feb 1, 2019

Whould you like to handle the issues?

One or more dependencies were identified with known vulnerabilities:
json-patch-1.6.jar: ids:(com.github.fge:json-patch:1.6, cpe:/a:json-patch_project:json-patch:1.6) : CVE-2018-14632
jackson-databind-2.9.5.jar: ids:(com.fasterxml.jackson.core:jackson-databind:2.9.5, cpe:/a:fasterxml:jackson:2.9.5, cpe:/a:fasterxml:jackson-databind:2.9.5) : CVE-2018-1000873, CVE-2018-14719, CVE-2018-14720, CVE-2018-14721, CVE-2018-19360, CVE-2018-19361, CVE-2018-19362
guava-20.0.jar: ids:(com.google.guava:guava:20.0, cpe:/a:google:guava:20.0) : CVE-2018-10237
slf4j-ext-1.6.3.jar: ids:(cpe:/a:slf4j:slf4j-ext:1.6.3, org.slf4j:slf4j-ext:1.6.3) : CVE-2018-8088
See the dependency-check report for more details.
:dependencyCheckAnalyze FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':dependencyCheckAnalyze'.
> 
  
  Dependency-Analyze Failure:
  One or more dependencies were identified with vulnerabilities that have a CVSS score greater then '5.0': CVE-2018-14719, CVE-2018-14720, CVE-2018-14721, CVE-2018-19360, CVE-2018-19361, CVE-2018-19362, CVE-2018-8088, CVE-2018-1000873
  See the dependency-check report for more details.

@nandhae
Copy link
Author

nandhae commented Feb 1, 2019 via email

@php-coder
Copy link

Whould you like to handle the issues?

If no one working on this, I can handle it or find someone else who will handle. Please, let me know if my help is required.

@Rajik
Copy link

Rajik commented Feb 1, 2019

I am working on that - you can expect a PR soon!

@nandhae nandhae deleted the vulnerability_fix branch February 4, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants