Merge pull request #6193 from firewave/fastdebug

removed the remaining bits of the FASTDEBUG/MAME_DEBUG_FAST silliness…

makefile

@@ -94,7 +94,6 @@
 # LTO = 1
 # SSE2 = 1
 # OPENMP = 1
-# FASTDEBUG = 1
 
 # SEPARATE_BIN = 1
 # PYTHON_EXECUTABLE = python3
@@ -810,10 +809,6 @@ ifdef OPENMP
 PARAMS += --OPENMP='$(OPENMP)'
 endif
 
-ifdef FASTDEBUG
-PARAMS += --FASTDEBUG='$(FASTDEBUG)'
-endif
-
 ifdef SEPARATE_BIN
 PARAMS += --SEPARATE_BIN='$(SEPARATE_BIN)'
 endif

scripts/genie.lua

@@ -337,15 +337,6 @@ newoption {
 	}
 }
 
-newoption {
-	trigger = "FASTDEBUG",
-	description = "Fast DEBUG.",
-	allowed = {
-		{ "0",   "Disabled"     },
-		{ "1",   "Enabled"      },
-	}
-}
-
 newoption {
 	trigger = "SEPARATE_BIN",
 	description = "Use separate bin folders.",
@@ -620,13 +611,6 @@ configuration { "Debug" }
 --      "BGFX_CONFIG_DEBUG=1",
 	}
 
-if _OPTIONS["FASTDEBUG"]=="1" then
-	defines {
-		"MAME_DEBUG_FAST",
-		"NDEBUG",
-	}
-end
-
 configuration { }
 
 if _OPTIONS["PROFILER"]=="1" then

src/emu/emucore.h

@@ -308,7 +308,7 @@ inline std::enable_if_t<!std::is_base_of<device_t, Source>::value> report_bad_ca
 template <typename Dest, typename Source>
 inline Dest downcast(Source *src)
 {
-#if defined(MAME_DEBUG) && !defined(MAME_DEBUG_FAST)
+#if defined(MAME_DEBUG)
 	Dest const chk(dynamic_cast<Dest>(src));
 	if (chk != src) report_bad_cast<std::remove_pointer_t<Dest>, Source>(src);
 #endif
@@ -318,7 +318,7 @@ inline Dest downcast(Source *src)
 template<class Dest, class Source>
 inline Dest downcast(Source &src)
 {
-#if defined(MAME_DEBUG) && !defined(MAME_DEBUG_FAST)
+#if defined(MAME_DEBUG)
 	std::remove_reference_t<Dest> *const chk(dynamic_cast<std::remove_reference_t<Dest> *>(&src));
 	if (chk != &src) report_bad_cast<std::remove_reference_t<Dest>, Source>(&src);
 #endif