Prevent mistakenly opening a search box in some situations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.key != .code` approach leads to wrongly capturing some unusual special keys as well as numpad keys used in non-numeric mode, and opening a search bar with the key name filled in. Non-character key names seem to consist of alphanumeric ASCII characters, so checking for that might be a more reliable heuristic.
`designMode` does not affect `isContentEditable` in Firefox, so the former must be checked separately.
`tagName` is uppercase in HTML and lowercase in XHTML mode. Use `localName`, which is always lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below some test cases to demonstrate the wrong behavior that each commit fixes.
Improve identifying keys as character keys
Press 2 on the numeric keypad while NumLock is off (it is used as an arrow key).
Deactivate on pages with design mode enabled
https://www-archive.mozilla.org/editor/midasdemo/.
Fix input field detection in XHTML documents
Try to enter a search query at https://golem.ph.utexas.edu/cgi-bin/MT-3.0/mt-search.cgi.