Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement shrink_to_fit method on StringInterner #3

Merged
merged 2 commits into from
Aug 13, 2017

Conversation

artemshein
Copy link
Contributor

It could be a good idea to be able to free unused memory after all strings are interned.

@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage decreased (-96.8%) to 0.0% when pulling e428f0e on artemshein:master into 5cf47d0 on Robbepop:master.

@Robbepop
Copy link
Owner

Thank you for the PR!
I haven't thought about this use case but it might be useful to some users.

Do you know why coveralls reports 0% coverage decrease?

@artemshein
Copy link
Contributor Author

I have no idea)

@Robbepop
Copy link
Owner

I found out the reason but it is strange that it did not break earlier ...
Tomorrow I will take some time and merge your PR! ;)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.016% when pulling 2c183f2 on artemshein:master into 069293b on Robbepop:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.016% when pulling 2c183f2 on artemshein:master into 069293b on Robbepop:master.

@coveralls
Copy link

coveralls commented Aug 13, 2017

Coverage Status

Coverage remained the same at 96.016% when pulling 2c183f2 on artemshein:master into 069293b on Robbepop:master.

@codecov-io
Copy link

codecov-io commented Aug 13, 2017

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files           3        3           
  Lines         251      251           
=======================================
  Hits          241      241           
  Misses         10       10
Impacted Files Coverage Δ
src/lib.rs 92.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069293b...2c183f2. Read the comment docs.

@Robbepop Robbepop merged commit ec2a80a into Robbepop:master Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants