V2 addon format and switch to pnpm, change localization and styles setup

[AmauryD]

Related issue: #1910
@RobbieTheWagner I began to work on this, but this will be a breaking change:

treeFor, treeForAddon, treeForAddonTemplates, treeForAddonTestSupport, treeForApp, treeForPublic, treeForStyles, treeForTemplates, treeForTestSupport, treeForVendor: Dropped. Dynamically generating broccoli trees at app build time is no longer supported. Your trees are built at publication time. If you need to produce different output at build time based on dynamic configuration, see Build-time Conditionals.

The theme and language part of flatpickr will be impacted.

[RobbieTheWagner]

@AmauryD yeah, we will need to tell people to import the themes and languages directly, which I think is fine.

[RobbieTheWagner]

Maybe flatpickr should be be a peerDep as well, so people ship all their own flatpickr stuff, but we provide the components on top.

[AmauryD]

@AmauryD yeah, we will need to tell people to import the themes and languages directly, which I think is fine.

Maybe flatpickr should be be a peerDep as well, so people ship all their own flatpickr stuff, but we provide the components on top.

I agree, let's do this !

[AmauryD]

@RobbieTheWagner I'm having a hard time figuring how to tell the user to import themes/default locales correctly. Does this seems ok to you ? https://github.com/shipshapecode/ember-flatpickr/blob/8ea4e52ba814e3ace92eff85077f5c0d626f9c16/test-app/app/templates/docs/usage.md
I only made the theme import work by using a js import. Didn't seems to work from the css stylesheet.

[AmauryD]

I'm currently testing this PR in one of my company's project. Seems to be working fine. Just some documentation to finish and it's ready.

[RobbieTheWagner]

@AmauryD what's the status on this?

[AmauryD]

@RobbieTheWagner should be ready for review !

[RobbieTheWagner]

@AmauryD can we add back the ember-try scenarios please?

[AmauryD]

is it necessary ? It's already tested by the test command. https://github.com/AmauryD/ember-flatpickr/blob/main/test-app/config/ember-try.js

https://github.com/AmauryD/ember-flatpickr/blob/6afd587d5806042b123cfe44531b398cede8485c/test-app/package.json#L35

[RobbieTheWagner]

The ember-try setup should remain as close to how it was before as possible for ease of upgrading.

[RobbieTheWagner]

Also, I don't know if it runs in CI at all now. We want each try scenario to be a separate run so we can see which ones pass and fail.

[AmauryD]

I understand. I'll fix this after work 😄
Thank's for the feedback by the way

[RobbieTheWagner]

Thank you for all your hard work on this!

[AmauryD]

The scenarios are back !

[RobbieTheWagner]

I think pretty much everything should stay as it was in this file and the old contents should be copied to the new ember-flatpickr folder, I think, to ensure the right things are ignored. Especially stuff like ember-try, which we want to keep.

[AmauryD]

Just to be sure, you prefer to keep the original content of this file at the project root ?

[AmauryD]

Downgraded test helpers from 3.x to 2.x to pass compatibility of ember-lts-4.4

[AmauryD]

Merry PR Chistmas 🎅 ⛄

[RobbieTheWagner]

Should we mention themes or is that mentioned elsewhere?

[AmauryD]

There's a brief section on this page: https://github.com/RobbieTheWagner/ember-flatpickr/blob/2b148eb050bbce62026f38dcf108ca085bcf49a5/test-app/app/templates/docs/usage.md#themes

[RobbieTheWagner]

Awesome work, thank you! There might be a few things we need to document a bit more, but I want to merge this so we don't keep getting conflicts.

[AmauryD]

Awesome work, thank you! There might be a few things we need to document a bit more, but I want to merge this so we don't keep getting conflicts.

You're welcome ! It was a pleasure ! 😄