Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in strict mode #248

Closed
RobertCordes opened this issue Oct 9, 2014 · 2 comments
Closed

Error in strict mode #248

RobertCordes opened this issue Oct 9, 2014 · 2 comments

Comments

@RobertCordes
Copy link

I got two global var errors when using dropkick in strict mode. I fixed it by doing the following:

  • In the for loop in the close method (line 316) I changed i = 0 to var i = 0
  • In the open method on line 332 I added direction to the var list

PS: I was a bit intimidated by your "Contributing" section, that's why I didn't create a pull request ;) But I still wanted to let you know in case someone else has the same problem. When you have to double click the generated select field this fix should work.

Robdel12 pushed a commit that referenced this issue Nov 11, 2014
@Robdel12
Copy link
Owner

Just out of curiosity what intimidated you?

@RobertCordes
Copy link
Author

Well, nothing about your contributing section in particular I guess. I just never created a pull request so I'm a bit unsure about this whole process and I don't want to do anything wrong or even break something ;) Still wanted to help, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants