[FIX] _enoughSpaceBelow + Avoids duplicate calls of functions #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• Changed the _enoughSpaceBelow _enoughSpace (checking both possibilities targeting to open the drop-down menu above or below) • Avoid duplicate calls of functions (as _openDropdown and _enoughSpaceBelow)
Robdel12
pushed a commit
that referenced
this pull request
Aug 10, 2013
[FIX] _enoughSpaceBelow + Avoids duplicate calls of functions
|
Hah thanks! You freed up my morning 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
As a heavy user and lover of this plugin, I decided to fix some problems in the current development version (1.1).
• Changed the _enoughSpaceBelow _enoughSpace (checking both possibilities targeting to open the drop-down menu above or below)
• Avoid duplicate calls of functions (as _openDropdown and _enoughSpaceBelow)
Hope I helped, and still intend to keep correcting other problems.