Improves mobile dropkick + performance boost #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• ADDITION : DK now reverts to the orginal selects on mobile while
still maintaining styled ".dk_toogle"
• ADDITION : Ability to force dropkick normal mobile through setting {
nativeMobile : false }
• IMPROVES : performance through chaining some operations
• IMPROVES : reset method
• FIX : setValue method now assesses the existence of the option in the
<select> before applying
• CLEAN : reload/refresh duplicated methods, now is just refresh
• CLEAN : things unused and redundant
|
This is awesome! I was going to get around to fixing DK on mobile but I haven't had time. Merging into version-1.3 branch |
|
I'm enjoying lots of fun and learning with this development! ;D Have two more things for today... [#145] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• ADDITION : DK now reverts to the orginal selects on mobile while
still maintaining styled ".dk_toogle"
• ADDITION : Ability to force dropkick normal mobile through setting {
nativeMobile : false }
• IMPROVES : performance through chaining some operations
• IMPROVES : reset method
• FIX : setValue method now assesses the existence of the option in the
before applying • CLEAN : reload/refresh duplicated methods, now is just refresh • CLEAN : things unused and redundant