Fix browser detection to make dropkick work in IE 10 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanselander
added a commit
to jonathanselander/DropKick
that referenced
this pull request
Dec 16, 2012
Fix browser detection to make dropkick work in IE 10
|
This really needs to get fixed asap. |
|
I try this and it seems to work: Modify the lign 16: |
|
Thank @babajem 👍 |
|
Thanks much. it is working for IE 10. |
|
Merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code as it stands reject IE10 as it thinks that it is a version < 7.
There seems to be an issue with rounded corners not working in IE10, but I couldn't see anywhere where border-radius was being set on a browser by browser basis. Perhaps an IE10 bug?