Fix clang compile failure when calling hash_combine() with wrong uint64_t type #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest main
It's only supported in DX12 so far.
CMakeLists fix for NVRHI shader compiler to support AppleClang
This reverts commit 6cd0688.
It's only supported in DX12 so far.
… type consistency (cherry picked from commit 9eb2a3a)
This was referenced Oct 13, 2023
RobertBeckebans
force-pushed
the
main
branch
3 times, most recently
from
1cbc9e9
to
bb9d8ae
Compare
|
No longer needed since this is now included in main at nvrhi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following:
hash_combine()in vulkan-resource-bindings.cpp when called with auint64_ttype. ChangedviewInfoHashto the expectedsize_ttype and now it compiles and works properly.ClearDepthStencilAttachment()stencil parameter touint8_tfor type consistency. This is the correct type size for calling functions and it also eliminates MSVC compiler warnings re potential loss of data when callingclearDepthStencilTexture()internally.