Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for metrics #434

Closed
Tracked by #116
RobertCraigie opened this issue Jun 26, 2022 · 0 comments · Fixed by #831
Closed
Tracked by #116

Add support for metrics #434

RobertCraigie opened this issue Jun 26, 2022 · 0 comments · Fixed by #831
Labels
kind/feature A request for a new feature. level/advanced priority/high process/candidate Candidate for the next release topic: client Related to the Client API
Projects
v1.0.0

Comments

@RobertCraigie
Copy link
Owner

RobertCraigie commented Jun 26, 2022 •
edited

Prisma have recently added support for retrieving metrics relating to the Prisma Client. We should support this too.

https://www.prisma.io/docs/concepts/components/prisma-client/metrics
@RobertCraigie RobertCraigie mentioned this issue Jun 26, 2022
Open
24 tasks
@RobertCraigie RobertCraigie added kind/feature A request for a new feature. level/advanced priority/high process/candidate Candidate for the next release topic: client Related to the Client API labels Nov 21, 2022
@RobertCraigie RobertCraigie added this to To do in v1.0.0 via automation Nov 21, 2022
@RobertCraigie RobertCraigie mentioned this issue Oct 22, 2023
Merged
8 tasks
v1.0.0 automation moved this from To do to Done Oct 22, 2023
RobertCraigie added a commit that referenced this issue Oct 22, 2023
@RobertCraigie @pre-commit-ci
feat(client): add support for metrics (#831)
9d63b8e 
## Change Summary

closes #434

TODO:
- [x] support globalLabels
- [x] check if int / float is right
- [x] test multiple client instances
- [x] document

## Checklist

- [ ] Unit tests for the changes exist
- [ ] Tests pass without significant drop in coverage
- [ ] Documentation reflects changes where applicable
- [ ] Test snapshots have been
[updated](https://prisma-client-py.readthedocs.io/en/latest/contributing/contributing/#snapshot-tests)
if applicable

## Agreement

By submitting this pull request, I confirm that you can use, modify,
copy and redistribute this contribution, under the terms of your choice.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature A request for a new feature. level/advanced priority/high process/candidate Candidate for the next release topic: client Related to the Client API
Projects
Prisma Client Python
Status: Done
v1.0.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): add support for metrics RobertCraigie/prisma-client-py
1 participant
@RobertCraigie