Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add support for transactions #427

Closed
wants to merge 13 commits into from
Closed

Conversation

RobertCraigie
Copy link
Owner

@RobertCraigie RobertCraigie commented Jun 14, 2022

Opening prematurely to track status of tests / linters. When I have to occasionally update this branch I forget which things are "intended" to fail at the moment, while it is easy to just reset in git, it's nice to have it here too.

closes #53

TODO:

  • call rollback() on error

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Base: 94.32% // Head: 36.78% // Decreases project coverage by -57.53% ⚠️

Coverage data is based on head (9c14c43) compared to base (c436345).
Patch coverage: 5.88% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #427       +/-   ##
===========================================
- Coverage   94.32%   36.78%   -57.54%     
===========================================
  Files         120      113        -7     
  Lines        6059     6002       -57     
  Branches     1037      457      -580     
===========================================
- Hits         5715     2208     -3507     
- Misses        301     3715     +3414     
- Partials       43       79       +36     
Impacted Files Coverage Δ
src/prisma/engine/utils.py 62.96% <0.00%> (-24.06%) ⬇️
tests/test_transactions.py 0.00% <0.00%> (ø)
src/prisma/errors.py 76.82% <75.00%> (-15.07%) ⬇️
tests/test_http.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_misc.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_batch.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_count.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_client.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_config.py 0.00% <0.00%> (-100.00%) ⬇️
tests/test_create.py 0.00% <0.00%> (-100.00%) ⬇️
... and 87 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@listepo
Copy link

listepo commented Dec 26, 2023

Any news?

@RobertCraigie
Copy link
Owner Author

@listepo this is already supported, this PR is old and outdated. https://prisma-client-py.readthedocs.io/en/stable/reference/transactions/

@RobertCraigie RobertCraigie deleted the wip/transactions branch December 26, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for transactions
2 participants