Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(partials): support combining exclude and exclude_relational_fields #437

Merged
merged 1 commit into from Jun 27, 2022

Conversation

RobertCraigie
Copy link
Owner

@RobertCraigie RobertCraigie commented Jun 27, 2022

Change Summary

Closes #436

This also enforces that include and exclude_relational_fields=True are mutually exclusive.

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #437 (57282a9) into main (c37ea68) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   94.15%   94.16%           
=======================================
  Files         114      114           
  Lines        5865     5874    +9     
  Branches      330      330           
=======================================
+ Hits         5522     5531    +9     
  Misses        303      303           
  Partials       40       40           
Impacted Files Coverage Δ
tests/test_generation/test_partial_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37ea68...57282a9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect PartialType fields when using include || exclude and exclude_relational_fields=True
1 participant