Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): Add support for interactive transactions #613

Merged
merged 42 commits into from
Jun 12, 2023
Merged

feat(client): Add support for interactive transactions #613

merged 42 commits into from
Jun 12, 2023

Conversation

RobertCraigie
Copy link
Owner

@RobertCraigie RobertCraigie commented Nov 27, 2022 •
edited
Loading

Change Summary

closes #53

This PR also bumps the typing-extensions version for NewType support.

TODO:

  • tests for behaviour wrt rollback
  • Check what max_wait does and document both options
  • Check if we need to bump the typing-extensions dep
  • Support for model based access
  • Fix synchronous tests
  • Docs (include timeout information)

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@RobertCraigie RobertCraigie marked this pull request as draft November 27, 2022 14:51
@RobertCraigie RobertCraigie changed the title Add support for interactive transactions feat(client): Add support for interactive transactions Jan 22, 2023
RobertCraigie and others added 24 commits January 22, 2023 12:37
@RobertCraigie
databases: add missing dep
575b8a5
@RobertCraigie
Try fix tests
bb1de54
@RobertCraigie
Fix tests & bump typing-extensions version
f122f85
@RobertCraigie
Fix client logging
9d566f5
@RobertCraigie
Add type annotation and improve debug messages
92d89fd
@RobertCraigie
Document timeout and max_wait arguments
b803d89
@RobertCraigie
Merge branch 'main' into feat/transactions
9113251
@RobertCraigie
Fix mypy
ccb41f8
@RobertCraigie
xfail broken tests
9fbe6ee
@RobertCraigie
Updates
26d21fe
@RobertCraigie
Merge branch 'main' into feat/transactions
727f954
@RobertCraigie
Merge branch 'main' into feat/transactions
5c24f24
@RobertCraigie
Remove engine reference counting
53fcf0c
@RobertCraigie
Merge branch 'main' into feat/transactions
28f4e1c
@RobertCraigie
Missed reference to new_ref()
c59d52b
@RobertCraigie
Skip broken test for SQLite + improve debug logs
e63ab30
@pre-commit-ci
chore(pre-commit.ci): auto fixes from pre-commit.com hooks
cf40527 
for more information, see https://pre-commit.ci
@RobertCraigie
docs
71c83f5
@pre-commit-ci
chore(pre-commit.ci): auto fixes from pre-commit.com hooks
2fdaa90 
for more information, see https://pre-commit.ci
@RobertCraigie
debug
6354e91
@RobertCraigie
debug
a00291c
@RobertCraigie
Try fix
71ef8b8
@RobertCraigie
Try fix
addbf6b
@RobertCraigie
Try fix
1c858fd
@RobertCraigie RobertCraigie marked this pull request as ready for review June 12, 2023 01:53
@RobertCraigie RobertCraigie merged commit cca0e85 into main Jun 12, 2023
28 checks passed
@RobertCraigie RobertCraigie deleted the feat/transactions branch June 12, 2023 02:01
github-actions bot added a commit that referenced this pull request Jun 12, 2023
@github-actions
feat(client): Add support for interactive transactions (#613)
f307b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for transactions
1 participant
@RobertCraigie