-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(internals): split more template files into standard python files #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
force-pushed
the
feat/async-refactor
branch
5 times, most recently
from
January 20, 2024 15:33
0b762e9
to
1d1d6e1
Compare
RobertCraigie
force-pushed
the
feat/async-refactor
branch
from
January 21, 2024 15:42
36c826c
to
4d34e95
Compare
So that it can be accessed pre-generation
There's no need for these to be in a template file
I want to move as much code as possible outside of templates and this will become more complicated in the future so it deserves it's own file
RobertCraigie
force-pushed
the
feat/async-refactor
branch
2 times, most recently
from
January 21, 2024 17:59
e3f2abd
to
858f659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Laying the ground work for using both the sync client and the async client at the same time.
Checklist
Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.