Ensure postfix is added to a global target (#220)

--------- Co-authored-by: Robert Craigie <robert@craigie.dev>
RobertCraigie · Oct 7, 2023 · 79ce523 · 79ce523
1 parent 45de41c
commit 79ce523
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -25,16 +25,6 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
         node: [12, 14, 16]
         python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
-        exclude:
-          - os: windows-latest
-            python-version: '3.12'
-            node: 12
-          - os: windows-latest
-            python-version: '3.12'
-            node: 14
-          - os: windows-latest
-            python-version: '3.12'
-            node: 16
 
     steps:
       - uses: actions/checkout@v3

diff --git a/pyright/node.py b/pyright/node.py
@@ -72,7 +72,9 @@ def _ensure_node_env(target: Target) -> Path:
 def _get_global_binary(target: Target) -> Optional[Path]:
     log.debug('Checking for global target binary: %s', target)
 
-    which = shutil.which(target)
+    path = target + _postfix_for_target(target)
+
+    which = shutil.which(path)
     if which is not None:
         log.debug('Found global binary at: %s', which)