I112 bad para in wikilinks #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line scanner was recognizing the | in a wikilink label as a table column separator. This eventually still got turned into a link, but by then, it was already wrapped in a Para block. To fix this, eat anything wrapped in double square brackets before looking for the table regex. Co-authored-by: Ben Olive <sionide21@gmail.com>
Pull Request Test Coverage Report for Build 96e7f6a2a3c4827c78e1323d93a68d390fa4aeb8-PR-114Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
RobertDober
force-pushed
the
i112-bad-para-in-wikilinks
branch
from
96e7f6a
to
a6e835a
Compare
RobertDober
added a commit
that referenced
this pull request
Oct 1, 2022
* Don't wrap labeled wikilinks in p tags (#113) The line scanner was recognizing the | in a wikilink label as a table column separator. This eventually still got turned into a link, but by then, it was already wrapped in a Para block. To fix this, eat anything wrapped in double square brackets before looking for the table regex. Co-authored-by: Ben Olive <sionide21@gmail.com> * Added RELEASE NOTES for 1.4.28 * modernised wikilinks tests * testing all: true implemented, bug for <sup> fixed * fixing doctest for 1.11 * Prepare rel 1.4.28 Co-authored-by: Ben Olive <sionide21@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.