Fix catastrophic backtracking in IAL regex #125
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
String.duplicate("a", 500_000) |> EarmarkParser.Helpers.extract_ial()
Unless you're running a supercomputer, the operation will stall and begin to hoard memory.
The root cause is that IAL regex is doing the "catastrophic backtracking". I couldn't find a way to prevent this while still matching the line before the IAL, so instead I changed the regex to only match IAL and used
Regex.split
to extract the line. Let me know if you see a better solution!We initially ran into this bug while parsing a file with base64-encoded image, so I added a test for exactly this test case.