Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I026 brittle footnotes #76

Merged
merged 8 commits into from
Dec 15, 2021
Merged

I026 brittle footnotes #76

merged 8 commits into from
Dec 15, 2021

Conversation

RobertDober
Copy link
Owner

No description provided.

@RobertDober
Fixes #26
2632cd5 
Next:

	- Compare to GFM links (all numbers)
	- Check order (fndefs and blocks inside fndefs)
	- Can I refactor parse_fn_defs -> module?
	- Can I refactor render_fn_list -> module?
	- Remove `#IO.inspect`
	- Check TODOs
@coveralls
Copy link

coveralls commented Dec 14, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 3a725f8692ec8837dc95fe9914396e9dab252c17-PR-76

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 154 of 165 (93.33%) changed or added relevant lines in 9 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+3.7%) to 95.824%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/earmark_parser/ast_renderer.ex 36 37 97.3%
lib/earmark_parser/enum/ext.ex 7 8 87.5%
lib/earmark_parser/parser.ex 74 83 89.16%
Files with Coverage Reduction New Missed Lines %
lib/earmark_parser/options.ex 2 80.0%
lib/earmark_parser/parser.ex 4 90.48%
Totals Coverage Status
Change from base Build 0354b8872604a2fd6bd2e09b485b1adf21c8a913: 3.7%
Covered Lines: 849
Relevant Lines: 886
💛 - Coveralls

@RobertDober RobertDober force-pushed the i026-brittle-footnotes branch 2 times, most recently from 5d206a5 to 90ab119 Compare December 14, 2021 19:59
@RobertDober
Better code coverage
3a725f8 
	- Removing dead code
	- Added missing tests
@RobertDober
Options.messages is now a MapSet
d08649b
@RobertDober
Removed (almost) all TODOS
1b76ee2
@RobertDober
Refactoring of footnote specific code
fb473a1 
	- Parsing → parser/footnote_parser.ex
	- Rendering → ast/renderer/footnote_renderer.ex
@RobertDober RobertDober force-pushed the i026-brittle-footnotes branch 2 times, most recently from 3cbbdb5 to 77b2427 Compare December 15, 2021 08:17
@RobertDober RobertDober merged commit 5797a53 into master Dec 15, 2021
@RobertDober RobertDober deleted the i026-brittle-footnotes branch December 15, 2021 08:26
@herminiotorres herminiotorres mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RobertDober @coveralls