New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unique key issue when number has multiple of the same digit. #10

Open

altany wants to merge 1 commit into RobertFOConnor:master from OLIOEX:fix-unique-key-issue

altany commented Jul 7, 2020

As reported here:
#1 (comment)

Hi @RobertFOConnor. This is still an issue in the latest version when there are two same digits in the number prop. I recommend you amend the index of the .map() to the data as a key, to ensure it will always be unique.

return (number + '').split('').map((data, index) => {
    <TextTicker
        key={`${data}${index}`}
        ...
    />
})

See screenshot when value is 199


          Make sure the TextTicker is unique

dcd4a83

By amending with the map index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment