Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some build issues #4

Closed
wants to merge 5 commits into from
Closed

fix some build issues #4

wants to merge 5 commits into from

Conversation

williamdemeo
Copy link

On my (fairly modern and comprehensive) TeX-Live installation (on Ubuntu 12.04 LTS), I could not compile the notes. I fixed this by adding a few protect commands to notes-week1.tex and by adding the tikz-cd.sty file to the repository. You might consider merging these changes into the main respository.

@williamdemeo

@favonia
Copy link
Collaborator

favonia commented Dec 18, 2013

Sorry about the late reply and thanks for the pull request. Would it be more readable to include etoolbox and use newrobustcmd directly? Personally I'm fine with tikz-cd.sty now, but Ubuntu 12.10 and beyond all include this package so I might remove it later.

@williamdemeo
Copy link
Author

Sorry, but I don't know about etoolbox or newrobestcmd.

As for readability, in my commit with the comment "the default red boxes..." I have made hyperref links blue instead of having red boxes drawn around them. This seems preferable to me, however, some people might not like it. That's why I made this a separate commit, in case you want to ignore this suggestion.

About pdflatex, this is the program that I normally use, and it was working for me even when the notes wouldn't compile with latexmk. However, I eventually got them to compile with latexmk, and that's why, in my last commit, I reverted back to latexmk.

I would suggest that my first two commits are worth pulling, since some people may prefer to stick with 12.04 LTS for now. However, my last three commits can be safely ignored, as they are matters of personal preference. If you would like me to close this pull request and submit another with only my first two commits, just let me know.

@favonia
Copy link
Collaborator

favonia commented Dec 24, 2013

The \newrobustcmd macro in the etoolbox package is similar to \newcommand but will define a robust macro. The problem is that some authors are using fragile macros within \section, and in your tex implementation they become broken (the implementation has lots of freedom here). \protect is a way to deal with it, and I'm thinking of replacing the \newcommand in question with \newrobustcmd to make the code more readable.

@favonia
Copy link
Collaborator

favonia commented Dec 24, 2013

This means the inclusion of tikz-cd.sty and either your first commit or the etoolbox solution. I am wondering what went wrong with latexmk, though. Personally I am entirely fine with the color change, and yes, a cleaned up branch would be great.

Thanks again for your help.

favonia added a commit that referenced this pull request Dec 26, 2013
Solve problems discovered by @williamdemeo.

- Add tikz-cd.sty for Ubuntu 12.04.
- Make \ac robust.
- Make other commands robust.
@favonia
Copy link
Collaborator

favonia commented Dec 26, 2013

Hi @williamdemeo I pushed a fix which realizes my ideas. Does it work for you? BTW, in addition to \robustify{\ac}, I also made other custom-defined commands robust.

@williamdemeo
Copy link
Author

Hi @favonia The computer I'm using right now is Ubuntu 13.04, so probably it doesn't help you to know that the cmu-2013-fall branch compiles fine on my machine. When I'm back on my 12.04 LTS machine again I'll try to compile and let you know if it works. Thanks.

@williamdemeo
Copy link
Author

I just verified that a fresh checkout of the cmu-2013-fall branch of hott-notes compiles fine on Ubuntu 12.04 with make command (after I did sudo apt-get install latexmk)

So I'm closing this issue and deleting the branch I created.

Nice work.

@williamdemeo williamdemeo deleted the wjd-suggests branch December 28, 2013 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants