Fix #61 #62
Merged
Fix #61 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix of RobertMyles#57 makes an assumption that all items contain a description tag. But it is not always the case and for those item `map(res_entry, "description", .default = def)` will be `NA` (the `def`) and the equality operator in the subsequent predicate function dies. I've included a simple test.
|
BTW, I think all map(blah) %>% unlistcan be replaced by purrr::map_chr(blah)don't you think? |
|
Hey @chainsawriot , thank you for the PR, much appreciated! I'm really struggling to find time to revisit this problem. As for I'll review your code and I'm running some tests on it and after I'll approve if all goes well. |
|
Hi @chainsawriot, thank you very much for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix of #57 makes an assumption that all items contain a
description tag. But it is not always the case and for those item
map(res_entry, "description", .default = def)will beNA(thedef) and the equality operator in the subsequent predicate function dies.I've included a simple test.