-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue-popperjs 3.0 - Upgrade to Popper.js v2.x #133
Draft
curtisbelt
wants to merge
13
commits into
RobinCK:master
Choose a base branch
from
curtisbelt-forks:popper.js-v2-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
vue-popperjs 3.0 - Upgrade to Popper.js v2.x #133
curtisbelt
wants to merge
13
commits into
RobinCK:master
from
curtisbelt-forks:popper.js-v2-migration
Commits on Mar 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1104577 - Browse repository at this point
Copy the full SHA 1104577View commit details -
Configuration menu - View commit details
-
Copy full SHA for d26dd55 - Browse repository at this point
Copy the full SHA d26dd55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d2a7f7 - Browse repository at this point
Copy the full SHA 6d2a7f7View commit details -
Remove all CSS margins (and some additional style updates)
https://popper.js.org/docs/v2/migration-guide/#4-remove-all-css-margins Additionally I updated the styles to (nearly) match the tutorial (https://popper.js.org/docs/v2/tutorial/).
Configuration menu - View commit details
-
Copy full SHA for ce67828 - Browse repository at this point
Copy the full SHA ce67828View commit details -
Configuration menu - View commit details
-
Copy full SHA for 296cc58 - Browse repository at this point
Copy the full SHA 296cc58View commit details -
Update method names: remove enableEventListeners/disableEventListeners
You can use setOptions method to change the scroll/resize options at will to replicate the original functionality here, but I did not notice any reason to do this. The resize/scroll listeners appear to be getting added/removed upon toggling the tooltip without any workaround here. https://popper.js.org/docs/v2/migration-guide/#8-update-method-names
Configuration menu - View commit details
-
Copy full SHA for d51caa4 - Browse repository at this point
Copy the full SHA d51caa4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad8db4d - Browse repository at this point
Copy the full SHA ad8db4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b66411 - Browse repository at this point
Copy the full SHA 6b66411View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc28ebf - Browse repository at this point
Copy the full SHA dc28ebfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d45dc6 - Browse repository at this point
Copy the full SHA 0d45dc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c47b1 - Browse repository at this point
Copy the full SHA b8c47b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6812626 - Browse repository at this point
Copy the full SHA 6812626View commit details
Commits on Mar 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for edbf63d - Browse repository at this point
Copy the full SHA edbf63dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.