Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes to catch up IDA Pro 7.0 #2

Closed
wants to merge 4 commits into from

Conversation

ntddk
Copy link

@ntddk ntddk commented Nov 5, 2017

Tested on IDA Pro 7.0.170914 Linux x86_64 with X-Tunnel malware described in X-Tunnel deobfuscation [Binsec + IDASec].

Unfortunately, backward compatibility will be broken due to IDA SDK update.
If this is a concern, let me consult with you.

@RobinDavid
Copy link
Owner

Hey @ntddk! Thanks! I had rather stopped contributing to idasec as I have stopped working on binsec but thanks for the pull request 👍 . I am in holiday in Tokyo for a week so I read and merge your request as I come back 😉

@ntddk
Copy link
Author

ntddk commented Nov 9, 2017

@RobinDavid
Wow, Are you in Tokyo now? Enjoy your trip and if it fits your schedule, please come AVTOKYO conference will be held this weekend.

@RobinDavid
Copy link
Owner

Yes I am. Arrggh, that does not fit my schedule, I had never heard about this conference maybe next time!

@RobinDavid
Copy link
Owner

Hi !
I had unpushed changes that switched from PySide to PyQt5 and which improved some dirty parts of the code. The code is way more clear. Thus, I need to deny your pull request. Static opaque analysis seems to works. Feel free to test it again 😉 .
(again I discontinued working on this plugin, and if I would need similar functionalities I'd might restart from scratch 😅 )

@RobinDavid RobinDavid closed this Nov 19, 2017
@ntddk
Copy link
Author

ntddk commented Nov 20, 2017

Hi, I respect your decision. I'm glad to see that you fixed some code issues. Anyway, thank you for taking your time! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants