Make socket location relative to location snapdrop client was served from #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds location.pathname to the socket location, this is needed to make snapdrop proxiable which allows it to be used as Home Assistant Addon.
…sistant Update Snapdrop client to be proxy friendly.
|
Currently the snapdrop home assistant addon uses this sed hack in a Dockerfile to work around the problem: RUN sed -i "s#const url = protocol + '://' + location.host + '/server' + webrtc;#const url = protocol + '://' + location.host + location.pathname + '/server' + webrtc;#" /app/snapdrop/client/scripts/network.jsMerging this pull would eliminate the need for that. |
Bellisario
approved these changes
Apr 8, 2021
kiprasmel
added a commit
to kiprasmel/snapdrop
that referenced
this pull request
Feb 26, 2024
simple solution: snapdrop.net/ -> room by IP snapdrop.net/foo -> room foo invalidates a previously faulty PR: SnapDrop#288 and provides an alternative: specify the `snapdrop_mount` if you app is deployed on a different URL than `/`.
kiprasmel
added a commit
to kiprasmel/snapdrop
that referenced
this pull request
Feb 26, 2024
simple solution: snapdrop.net/ -> room by IP snapdrop.net/foo -> room foo, no matter what IP invalidates a previously faulty PR: SnapDrop#288 and provides an alternative: specify the `snapdrop_mount` if you app is deployed on a different URL than `/`. it's not a "hack" to substitute the path via a command, like the home assistant guys used to do [1] -- it's normal, because you're doing a non-standard deployment. i just simplified how it'd need to be done now, while for everyone else, the easy room switching becomes available. [1] deftdawg/homeassistant-addons@29f99c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes snapdrop client look for its web socket relative to where the client page was served from, this makes it so the client can be proxied from URLs other than /. It's needed so that the client can be proxied by home assistant (which exposes the container under a path and /server does not work to find the socket).