Ensure that the types are generated properly
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVipond
force-pushed
the
publish-types
branch
from
1769a77
to
6763719
Compare
RobinMalfait
changed the title
types for the library are generated properly
RobinMalfait
changed the title
types for the library are generated properlytypes are generated properly
|
Hey, thanks so much for this contribution! 🙏 I indeed lost that information 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in the insiders build that we lost type definitions—this PR restores them.
Once I added the
--dtsflag, I started getting TS errors forpipeandcompose, sincereduceandreduceRightonly want to operate onFn, not the union type. The type assertion is a decent workaround, but I don't love it—maybe you know a better way to fix.