Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing ts-node with swc-node/register #1210

Merged
merged 15 commits into from
Oct 6, 2023
Merged

Replacing ts-node with swc-node/register #1210

merged 15 commits into from
Oct 6, 2023

Conversation

RobinTail
Copy link
Owner

Closes #1170

It seems that ts-node is abandoned by its maintainers, so I'm going to replace it by swc-node/register the same way I did for merge-sx.

@RobinTail RobinTail added dependencies Pull requests that update a dependency file refactoring The better way to achieve the same result external bug it's a bug, but in a dependency labels Oct 6, 2023
@RobinTail
Copy link
Owner Author

RobinTail commented Oct 6, 2023 •
edited
Loading

It's all running good locally but there is some issue with spawn in CI, need to figure out why

@RobinTail RobinTail changed the title Replacing ts-node Replacing ts-node with swc-node/register Oct 6, 2023
@RobinTail
Copy link
Owner Author

Final weird issue with running ESM test on Node 18.0.0:

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/runner/work/express-zod-api/express-zod-api/tests/esm/F.js' imported from /home/runner/work/express-zod-api/express-zod-api/tests/esm/

@RobinTail RobinTail force-pushed the no-ts-node branch 4 times, most recently from a64e62c to 5247630 Compare October 6, 2023 23:28
@RobinTail RobinTail added the CI/CD label Oct 6, 2023
@RobinTail RobinTail mentioned this pull request Oct 6, 2023
Closed
@RobinTail RobinTail marked this pull request as ready for review October 6, 2023 23:41
RobinTail
RobinTail commented Oct 6, 2023
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operational now

@RobinTail RobinTail merged commit 2c9d245 into master Oct 6, 2023
9 checks passed
@RobinTail RobinTail deleted the no-ts-node branch October 6, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD dependencies Pull requests that update a dependency file external bug it's a bug, but in a dependency refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Restore SWC for ts-node when new version released
1 participant
@RobinTail