Feat: beforeRouting option
#1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pulled this branch from v16.7.0-beta1 and tested - works great! Indeed dreamy ;-). Nicely designed, keeping it in the server spec of createConfig. Awesome work, thank you very much. |
RobinTail
added a commit
that referenced
this pull request
Feb 19, 2024
The feature you've been probably dreamed about. Based on the discussion #1547. This can enable `createServer` to be a standard approach in many cases where currently only the `attachRouting` one is working. Example UI served by a third-party middleware on its own route. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature you've been probably dreamed about.
Based on the discussion #1547.
This can enable
createServerto be a standard approach in many cases where currently only theattachRoutingone is working.Example UI served by a third-party middleware on its own route.