Fixing uncaught exception when using limitError
#1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
commented
Mar 2, 2024
RobinTail
force-pushed
the
fix-uncaught-when-limit-error
branch
from
7594269
to
9c3614e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
limitHandlerofexpress-fileuploadcalled asynchronously for a failed file before finishing the upload.In the end
express-fileuploadcallsnext().All that leads to calling
next()multiple times which leads to uncaught exception due to the way the error handling in express is organised.The
next()must be called once after completing the file processing.