Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer Map dictionaries #1731

Merged
merged 11 commits into from
May 5, 2024
Merged

Prefer Map dictionaries #1731

merged 11 commits into from
May 5, 2024

Conversation

RobinTail
Copy link
Owner

For performance reasons and modernity.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label May 5, 2024
Copy link

coveralls-official bot commented May 5, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling d86dd0e on prefer-map-dict
into d118e3b on master.

@RobinTail RobinTail marked this pull request as ready for review May 5, 2024 20:23
@RobinTail
Copy link
Owner Author

RobinTail commented May 5, 2024

That gave 3% performance improvement to ensureUniqOperationId for "create" + "update" case.

   ✓ Experiment (2) 11627ms
     name              hz     min     max    mean     p75     p99    p995    p999     rme  samples
   · original  164,226.13  0.0057  0.3901  0.0061  0.0061  0.0069  0.0076  0.0122  ±0.12%   821131
   · featured  168,904.64  0.0055  0.4062  0.0059  0.0059  0.0070  0.0086  0.0123  ±0.14%   844524   fastest

When testing on thousands of calls, the expected benefit is above 13%

   ✓ Experiment (2) 1480ms
     name              hz     min     max    mean     p75     p99    p995    p999     rme  samples
   · original  330,083.87  0.0024  2.9041  0.0030  0.0029  0.0037  0.0046  0.0187  ±2.46%   165042
   · featured  373,361.59  0.0023  1.3683  0.0027  0.0026  0.0029  0.0031  0.0158  ±2.05%   186681   fastest

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit 74b0abe into master May 5, 2024
11 checks passed
@RobinTail RobinTail deleted the prefer-map-dict branch May 5, 2024 21:30
RobinTail added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring The better way to achieve the same result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant