Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header params are missing or duplicated #1769

Merged
merged 8 commits into from
May 15, 2024
Merged

Header params are missing or duplicated #1769

merged 8 commits into from
May 15, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented May 15, 2024 •
edited

Fixes #1768

  1. Body depiction does not exclude header params (only path params);
  2. Params depiction only depicts header params when query is enabled as input source.

@RobinTail RobinTail added the coverage Additional tests label May 15, 2024
@RobinTail RobinTail mentioned this pull request May 15, 2024
Closed
@RobinTail RobinTail added the bug Something isn't working label May 15, 2024
@RobinTail RobinTail changed the title Header params: Additional test for POST method Header param is duplicated in the depiction of request body May 15, 2024
@RobinTail RobinTail linked an issue May 15, 2024 that may be closed by this pull request
Duplicated headers in request body in generated docs (POST, PATCH, etc.) #1768
Closed
@RobinTail RobinTail changed the title Header param is duplicated in the depiction of request body Header params missing or duplicated May 15, 2024
@RobinTail RobinTail changed the title Header params missing or duplicated Header params are missing or duplicated May 15, 2024
@RobinTail RobinTail marked this pull request as ready for review May 15, 2024 21:33
RobinTail
RobinTail commented May 15, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

RobinTail
RobinTail commented May 15, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@RobinTail RobinTail merged commit af02e67 into master May 15, 2024
11 checks passed
@RobinTail RobinTail deleted the issue-1768-header-params branch May 15, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working coverage Additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated headers in request body in generated docs (POST, PATCH, etc.)
1 participant
@RobinTail