Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger instance recognition failure #1773

Merged
merged 7 commits into from
May 16, 2024
Merged

Logger instance recognition failure #1773

merged 7 commits into from
May 16, 2024

Conversation

RobinTail
Copy link
Owner

Fixes #1772

@RobinTail RobinTail added the bug Something isn't working label May 16, 2024
@RobinTail RobinTail force-pushed the issue-1772-logger-instance-recognition-failure branch from 97ac9b4 to 1156ce1 Compare May 16, 2024 18:10
RobinTail
RobinTail commented May 16, 2024
View reviewed changes
tests/unit/logger.spec.ts Outdated Show resolved Hide resolved
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented May 16, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 728f940 on issue-1772-logger-instance-recognition-failure
into 0c9d793 on master.

@RobinTail RobinTail marked this pull request as ready for review May 16, 2024 18:34
RobinTail
RobinTail commented May 16, 2024
View reviewed changes
tests/unit/logger.spec.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented May 16, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail
Copy link
Owner Author

✅ QA passed

RobinTail
RobinTail commented May 16, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit 8670f90 into master May 16, 2024
11 checks passed
@RobinTail RobinTail deleted the issue-1772-logger-instance-recognition-failure branch May 16, 2024 19:05
RobinTail added a commit that referenced this pull request May 16, 2024
@RobinTail
Backport of #1773 8670f90 that fixes #1772 that may occur in v18.
b320855
@RobinTail RobinTail mentioned this pull request May 16, 2024
Merged
RobinTail added a commit that referenced this pull request May 18, 2024
@RobinTail
Backport of #1773 for v18 (#1774)
131f2b6 
Backport of #1773 that fixes #1772 that may occur in v18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customising logger with winston erroring out in v19
1 participant
@RobinTail