Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev1 #109

Merged
merged 137 commits into from
Oct 28, 2017
Merged

Rev1 #109

merged 137 commits into from
Oct 28, 2017

Conversation

Robinlovelace
Copy link
Collaborator

No description provided.

Nowosad and others added 30 commits October 21, 2017 12:42
@Nowosad
rev.md added
f1dc6e7
@Nowosad
moved q
dd85ff9
@Nowosad
q merge
f312fc0
@Nowosad
phase updated
005e9b5
@Robinlovelace
geolibrary -> spatial library and example
43e4a33
@Robinlovelace
Merge branch 'rev1' of github.com:Robinlovelace/geocompr into rev1
df1b821
@Robinlovelace
Update rev.md
64c18ba
@Robinlovelace
Update review
b072e59
@Nowosad
right arrow removed
1aaae3c
@Nowosad
geostatistical -> spatial statistics
d884ac8
@Robinlovelace
Address reviewer issue regarding sp and the tidyverse
0c94b3a
@Robinlovelace
Merge branch 'rev1' of github.com:Robinlovelace/geocompr into rev1
f326aaa
@Nowosad
delete (such as GEOS as GDAL)
c7e9b4d
@Nowosad
updated rev
51badfc
@Robinlovelace
functions -> scripts and functions (more general, lower expectations)
f366375
@Robinlovelace
Update text in c1 - more accessible
575f547
@Robinlovelace
Improve flow in c1 and link to wider open source movement
801f98e
@Nowosad
MULTIPOLYGON s -> MULTIPOLYGON geometries
4e56725
@Nowosad
sf classes update
7378344
@Nowosad
delete "Figure based on the Open Geospatial Consortium document [06-1…
d03067d 
…03r4](http://www.opengeospatial.org/standards/sfa)." statement
@Robinlovelace
Refactor section 1.3.
8a53516 
See what you think @jannes-m - I think this reads better now, is less colloquial while being simultaneously more concise.

However the content you added was excellent - I've aimed to clarify the message.
@Robinlovelace
Merge branch 'rev1' of github.com:Robinlovelace/geocompr into rev1
6d3a600
@Robinlovelace
Fix issue with 'you'
cf23f78 
@jannes-m I think this is a good example of when 'you' is too colloquial and not text-booky enough. I've tried to use a more formal style. Also - do we all advise our students to start with Python (see next commit)?
@Robinlovelace
Generalise discussion of Python.
4a0981d 
You happy with this @jannes-m ?
@Robinlovelace
Mention IDEs and that RStudio is a Java program!
e1e4e6b
@Robinlovelace
Minor improvement to grammar
6d4c5f4
@Robinlovelace
Refine index prose
25c71af 
Building on work by @Nowosad.

Aiming to make it more concise and simple, see OK to you?
@Robinlovelace
Fix #101
4e302b7 
Any other places where we said sf is cutting edge? Let me know if so @Nowosad and @jannes-m
@Robinlovelace
Add hyperlink to the R Journal
40dea54
@Robinlovelace
sf is no longer described as bleeding edge
74d7df5
@Robinlovelace
Copy link
Collaborator Author

@Nowosad and @jannes-m great work, we've fixed nearly all the issues! Should I merge this now or wait for the final ones to be finished (I can get mine done tomorrow).

@Robinlovelace
Copy link
Collaborator Author

Heads-up @Nowosad this is failing on Travis as it uses the dev version of spData. Merging anyway - it's an impressive amount of work in the PR that will be good to get out there asap.

@Robinlovelace Robinlovelace merged commit b880eb8 into master Oct 28, 2017
@Robinlovelace Robinlovelace deleted the rev1 branch October 30, 2017 15:09
@Robinlovelace Robinlovelace mentioned this pull request May 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Robinlovelace @Nowosad @jannes-m