-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing AssetTypes #513
base: main
Are you sure you want to change the base?
Conversation
I have no clue what the bot is asking me to do |
Hi @karl-police , As for what the bot is saying, it basically means that enums need to be edited at the source, and only the summary/description of existing enum items can be modified to maintain sync integrity between engine/docs. |
Two ways. One was by using Asset Ids and comparing them with the webpack resources from Roblox. Then I compared them with GitHub Repositories, no clue where they got the IDs from, maybe there's some stuff I missed out in webpack. The repositories were found purely by searching the Enum Name terms.
SolidModel (39): https://economy.roblox.com/v2/assets/2101493884/details LocalizationTableManifest (59): https://economy.roblox.com/v2/assets/17018879636/details TexturePack (63): https://economy.roblox.com/v2/assets/17018879391/details MeshHiddenSurfaceRemoval (75): https://economy.roblox.com/v2/assets/17028878663/details
It's not incorrect them not appearing in
I do wonder though what the asset type HTML is used for. |
This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏 |
noooooo |
Apologies for the delay... I'm looking into this further. :) |
Changes
This adds missing AssetTypes (probably needs to be updated internally on the API definition)
These informations come from the Webpack of Roblox and a few AssetIds that confirm the same values.
This is also good to update, because "CodeSnippets" is definitely gonna appear somewhere around the MarketplaceService in the future.
Checks
By submitting your pull request for review, you agree to the following: