Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AssetTypes #513

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

karl-police
Copy link
Contributor

@karl-police karl-police commented Apr 20, 2024

Changes

This adds missing AssetTypes (probably needs to be updated internally on the API definition)

These informations come from the Webpack of Roblox and a few AssetIds that confirm the same values.

This is also good to update, because "CodeSnippets" is definitely gonna appear somewhere around the MarketplaceService in the future.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@karl-police karl-police requested a review from a team as a code owner April 20, 2024 17:11
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Apr 20, 2024
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Apr 20, 2024
@karl-police
Copy link
Contributor Author

I have no clue what the bot is asking me to do

@IgnisRBX
Copy link
Contributor

IgnisRBX commented May 6, 2024

Hi @karl-police ,
Could you please provide more context on where you gathered all of these additions? When using Studio's autocomplete (i.e. type Enum.AssetType.[], none of these additions appears in the suggestion popup.

As for what the bot is saying, it basically means that enums need to be edited at the source, and only the summary/description of existing enum items can be modified to maintain sync integrity between engine/docs.

@karl-police
Copy link
Contributor Author

karl-police commented May 6, 2024

Hi @karl-police , Could you please provide more context on where you gathered all of these additions? When using Studio's autocomplete (i.e. type Enum.AssetType.[], none of these additions appears in the suggestion popup.

As for what the bot is saying, it basically means that enums need to be edited at the source, and only the summary/description of existing enum items can be modified to maintain sync integrity between engine/docs.

Two ways. One was by using Asset Ids and comparing them with the webpack resources from Roblox.

Then I compared them with GitHub Repositories, no clue where they got the IDs from, maybe there's some stuff I missed out in webpack. The repositories were found purely by searching the Enum Name terms.

 

SolidModel (39): https://economy.roblox.com/v2/assets/2101493884/details

LocalizationTableManifest (59): https://economy.roblox.com/v2/assets/17018879636/details

TexturePack (63): https://economy.roblox.com/v2/assets/17018879391/details

MeshHiddenSurfaceRemoval (75): https://economy.roblox.com/v2/assets/17028878663/details

 

It's not incorrect them not appearing in Enum.AssetType. It looks like internally they were not added onto that Enum list, so they're missing.

 

I do wonder though what the asset type HTML is used for.

Copy link

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

@github-actions github-actions bot added the stale label May 21, 2024
@karl-police
Copy link
Contributor Author

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

noooooo

@github-actions github-actions bot removed the stale label May 21, 2024
@IgnisRBX
Copy link
Contributor

Apologies for the delay... I'm looking into this further. :)

@Roblox Roblox deleted a comment Jun 7, 2024
@Roblox Roblox deleted a comment from Sazankhan Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation
Projects
None yet
2 participants