Use group status to report exit code (#41)

Roblox · Jan 28, 2022 · 7a037d9 · 7a037d9
1 parent c0eece4
commit 7a037d9
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased Changes
 
+- Report correct exit code ([#41](https://github.com/Roblox/foreman/pull/41))
 - Improve error handling to reduces crashes and add more useful error messages ([#40](https://github.com/Roblox/foreman/pull/40))
 - Add environment variable to override Foreman home directory ([#39](https://github.com/Roblox/foreman/pull/39))
 - Support tools hosted on GitLab ([#31](https://github.com/Roblox/foreman/pull/31))

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -15,6 +15,7 @@ edition = "2018"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
+command-group = "1.0.8"
 dirs = "4.0.0"
 env_logger = "0.9.0"
 log = "0.4.14"

diff --git a/src/tool_cache.rs b/src/tool_cache.rs
@@ -6,6 +6,7 @@ use std::{
     process,
 };
 
+use command_group::CommandGroup;
 use semver::Version;
 use serde::{Deserialize, Serialize};
 use zip::ZipArchive;
@@ -36,7 +37,7 @@ impl ToolCache {
 
         let status = process::Command::new(&tool_path)
             .args(args)
-            .status()
+            .group_status()
             .map_err(|err| {
                 ForemanError::io_error_with_context(err,
                     format!(