Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging options and output #30

Merged
merged 7 commits into from
Jan 5, 2022
Merged

Improve logging options and output #30

merged 7 commits into from
Jan 5, 2022

Conversation

matthargett
Copy link
Contributor

@matthargett matthargett commented Nov 13, 2021 •
edited

  • Add ability to increase logging level from the commandline.
  • Default to 'info' level.
  • Add an info-level log message explaining when a release version tag name isn't being used.

Closes #27

@matthargett
Add ability to increase logging level from the commandline. Default t…
4b63fe4 
…o 'info' level. Add a log message explaining when a release version tag name isn't being used.
@github-actions
Copy link

github-actions bot commented Nov 13, 2021 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matthargett
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

ZoteTheMighty
ZoteTheMighty approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid; I might make the suggestion that we align to what rotriever does and shift the levels up by one:

  • no arg is info
  • -v is debug
  • -vv is `trace

ZoteTheMighty
ZoteTheMighty reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that I missed before, otherwise I think this looks good

src/tool_cache.rs Show resolved Hide resolved
ZoteTheMighty
ZoteTheMighty approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good!

@oltrep oltrep merged commit 9ea7e10 into master Jan 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oltrep oltrep oltrep left review comments

@ZoteTheMighty ZoteTheMighty ZoteTheMighty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Foreman should provide output feedback when running install
3 participants
@matthargett @oltrep @ZoteTheMighty