Keep using ubuntu-20.04 in GitHub Actions (and clang++-10 in coverage) #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcope-rbx
reviewed
Jan 6, 2023
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: install | ||
| run: | | ||
| sudo apt install llvm | ||
| - name: make coverage | ||
| run: | | ||
| CXX=clang++ make -j2 config=coverage native=1 coverage | ||
| CXX=clang++-10 make -j2 config=coverage native=1 coverage |
There was a problem hiding this comment.
I am assuming we are being explicit about the clang version here so we don't unintentionally run on an version of clang without the support we need?
There was a problem hiding this comment.
This is restoring the specific version we had earlier.
As far as I understand, later versions available on 20.04 generate worse coverage locations. It might be fixed in 14/15, but that needs 22.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ubuntu-latest was updated to 22.04 which removes clang++-10 we used for coverage stats and creates a pre-compiled binary that requires a glibc upgrade #773
Solution
Pin to ubuntu-20.04 using multi-value matrix configurations.
In coverage configuration, we use clang++-10 once again.