Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luau 0.559 build failure #806

Closed
chenrui333 opened this issue Jan 16, 2023 · 3 comments Β· Fixed by #810
Closed

luau 0.559 build failure #806

chenrui333 opened this issue Jan 16, 2023 · 3 comments Β· Fixed by #810
Assignees
Labels
bug Something isn't working

Comments

@chenrui333
Copy link

πŸ‘‹ trying to build the latest release, but run into some build issue. The error log is as below:

build issue
  /tmp/luau-20230114-3624-1edzeko/luau-0.559/CodeGen/src/EmitCommonX64.cpp:254:64: error: β€˜tm’ is not a constant expression
    254 |     build.mov(rArg3, qword[rax + offsetof(global_State, tmname[tm])]);
        |                                                                ^~

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/3916145999/jobs/6708193446
relates to Homebrew/homebrew-core#120570

@chenrui333 chenrui333 added the bug Something isn't working label Jan 16, 2023
@chenrui333
Copy link
Author

Note, the 0.558 release build was successful, which includes clang++-10 change

@chenrui333
Copy link
Author

This is my config setup in case it is helpful

Clang: 14.0.0
Git: 2.39.0 => /bin/git
Curl: 7.81.0 => /bin/curl
Kernel: Linux 5.15.0-1030-azure x86_64 GNU/Linux
OS: Ubuntu 22.04.1 LTS (jammy)
Host glibc: 2.35
/usr/bin/gcc: 11.3.0
/usr/bin/ruby: 3.0.2
glibc: N/A
gcc@11: N/A
gcc: N/A
xorg: N/A

@vegorov-rbx vegorov-rbx self-assigned this Jan 17, 2023
@vegorov-rbx
Copy link
Collaborator

A fix will be included in the next release.

-    build.mov(rArg3, qword[rax + offsetof(global_State, tmname[tm])]);
+    build.mov(rArg3, qword[rax + offsetof(global_State, tmname) + tm * sizeof(TString*)]);

vegorov-rbx added a commit that referenced this issue Jan 20, 2023
* For autocomplete, additional information is included in Scope for type
alias name locations and names of imported modules
* Improved autocomplete suggestions in 'for' and 'while' loop headers
* String match functions return types are now optional strings and
numbers because match is not guaranteed at runtime
* Fixed build issue on gcc 11 and up (Fixes
#806)
RomanKhafizianov pushed a commit to RomanKhafizianov/luau that referenced this issue Nov 27, 2023
* For autocomplete, additional information is included in Scope for type
alias name locations and names of imported modules
* Improved autocomplete suggestions in 'for' and 'while' loop headers
* String match functions return types are now optional strings and
numbers because match is not guaranteed at runtime
* Fixed build issue on gcc 11 and up (Fixes
luau-lang/luau#806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants