Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Stderr and stdout of existing processes are lost after a restart of nomad #110

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

shishir-a412ed
Copy link
Contributor

Fixes #108

Signed-off-by: Shishir Mahajan smahajan@roblox.com

@shishir-a412ed shishir-a412ed requested a review from a team September 10, 2021 23:59
@shishir-a412ed shishir-a412ed self-assigned this Sep 10, 2021
@shishir-a412ed shishir-a412ed force-pushed the stdout_stderr_issue branch 4 times, most recently from 87acdda to ff6404e Compare September 13, 2021 18:02
Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
Copy link
Collaborator

@chuckyz chuckyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we port any of this to the writing a driver documentation upstream? So other drivers won't encounter this in the future?

@shishir-a412ed shishir-a412ed merged commit 5168f15 into master Sep 13, 2021
@shishir-a412ed shishir-a412ed deleted the stdout_stderr_issue branch September 13, 2021 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdin and stdout of existing processes are lost after a restart of nomad
2 participants